frontend Sidebar: Improve performance by moving isSelected logic to the parent component #2638
+50
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sniok
force-pushed
the
sidebar-perf
branch
2 times, most recently
from
6b65c95 to
11382dd
Compare
dosubot
bot
added
the
size:L
illume
requested changes
Dec 30, 2024
| @@ -14,7 +14,7 @@ import { SidebarEntry } from './sidebarSlice'; | |||
| */ | |||
| export interface SidebarItemProps extends ListItemProps, SidebarEntry { | |||
| /** The route name which is selected. */ | |||
There was a problem hiding this comment.
The documentation should be updated as well.
| > | ||
| <a | ||
| class="MuiButtonBase-root MuiListItem-root MuiListItem-gutters MuiListItem-padding MuiListItem-button css-sayhe9-MuiButtonBase-root-MuiListItem-root" | ||
| class="MuiButtonBase-root MuiListItem-root MuiListItem-gutters MuiListItem-padding MuiListItem-button Mui-selected css-sayhe9-MuiButtonBase-root-MuiListItem-root" |
There was a problem hiding this comment.
Can you please explain why this test result changed? I don't see any mention of why, so I'm wondering if it's intentional or a bug?
There was a problem hiding this comment.
I incorrectly updated the story for this case. It's fixed now
dosubot
bot
added
size:M
Change logic that determines if the item is selected to the parent component. This allows for better memoization of individual items. Signed-off-by: Oleksandr Dubenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change only items that were updated will rerender